Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63656 )
Change subject: mb/msi/ms7d25: Configure PCIe Root Ports ......................................................................
Patch Set 12: Verified-1
(57 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/afbad3b2_1deef7e3 PS12, Line 142: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/ef1dc003_e348b5e2 PS12, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/864e7754_3e29480d PS12, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/f2e930f9_4fe381f7 PS12, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/f582635d_9a7f66ce PS12, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/fea5a742_c9c6b9cd PS12, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/00c802ae_e2573db8 PS12, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/5254f97e_07c533b9 PS12, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/068b9ad4_0273709a PS12, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/0854abf0_9ec5ec9e PS12, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/00d8c1e9_f702f598 PS12, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/0d51ab77_c558bfe8 PS12, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/e37dec5a_611daf5d PS12, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/aab83ce2_3f72ece2 PS12, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/2689e750_f693ed8c PS12, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/3d3bdc58_bb97f0cd PS12, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/b5442ca6_3df89b65 PS12, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/b56b1028_fbc035e3 PS12, Line 425: // _PAD_CFG_STRUCT(VGPIO_PCIE_0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/3c7eeec8_a559d5ad PS12, Line 426: // _PAD_CFG_STRUCT(VGPIO_PCIE_1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/32d3f6bc_b8cb783d PS12, Line 427: // _PAD_CFG_STRUCT(VGPIO_PCIE_2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/df83a1db_bd88f7b5 PS12, Line 428: // _PAD_CFG_STRUCT(VGPIO_PCIE_3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/cda8bf98_dfa8750b PS12, Line 429: // _PAD_CFG_STRUCT(VGPIO_PCIE_4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/e14dfb24_ec0260a1 PS12, Line 430: // _PAD_CFG_STRUCT(VGPIO_PCIE_5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/03c46938_dab4a594 PS12, Line 431: // _PAD_CFG_STRUCT(VGPIO_PCIE_6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/8d966224_82bf54ce PS12, Line 432: // _PAD_CFG_STRUCT(VGPIO_PCIE_7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/a0670862_bcc52e55 PS12, Line 433: // _PAD_CFG_STRUCT(VGPIO_PCIE_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/1c93cb2e_80e187ca PS12, Line 434: // _PAD_CFG_STRUCT(VGPIO_PCIE_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/a66e66e2_664fcefb PS12, Line 435: // _PAD_CFG_STRUCT(VGPIO_PCIE_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/5567e348_864edb50 PS12, Line 436: // _PAD_CFG_STRUCT(VGPIO_PCIE_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/66c570a5_5c2ccf01 PS12, Line 437: // _PAD_CFG_STRUCT(VGPIO_PCIE_12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/e285ba01_a4538a88 PS12, Line 438: // _PAD_CFG_STRUCT(VGPIO_PCIE_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/8911f510_41172c02 PS12, Line 439: // _PAD_CFG_STRUCT(VGPIO_PCIE_14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/1c9526ce_47e7233b PS12, Line 440: // _PAD_CFG_STRUCT(VGPIO_PCIE_15, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/f9a4a66a_a22668e1 PS12, Line 441: // _PAD_CFG_STRUCT(VGPIO_PCIE_64, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/ce52f2f6_a983d96e PS12, Line 442: // _PAD_CFG_STRUCT(VGPIO_PCIE_65, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/5c1e099d_bee118fc PS12, Line 443: // _PAD_CFG_STRUCT(VGPIO_PCIE_66, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/3c44d6f8_a63105a6 PS12, Line 444: // _PAD_CFG_STRUCT(VGPIO_PCIE_67, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/3eb8f928_28c57e5f PS12, Line 447: // _PAD_CFG_STRUCT(VGPIO_PCIE_16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/579100b1_14aa9b15 PS12, Line 448: // _PAD_CFG_STRUCT(VGPIO_PCIE_17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/9e08a3d8_2ae0d3e6 PS12, Line 449: // _PAD_CFG_STRUCT(VGPIO_PCIE_18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/557db5b8_3b352beb PS12, Line 450: // _PAD_CFG_STRUCT(VGPIO_PCIE_19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/8421c98f_41da35da PS12, Line 451: // _PAD_CFG_STRUCT(VGPIO_PCIE_20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/0c432e02_b57ee05d PS12, Line 452: // _PAD_CFG_STRUCT(VGPIO_PCIE_21, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/4ba84917_dd15f33a PS12, Line 453: // _PAD_CFG_STRUCT(VGPIO_PCIE_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/d2643cef_68c9091e PS12, Line 454: // _PAD_CFG_STRUCT(VGPIO_PCIE_23, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/c50f1a01_5a771243 PS12, Line 455: // _PAD_CFG_STRUCT(VGPIO_PCIE_24, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/47e1a1a9_f3a0c55c PS12, Line 456: // _PAD_CFG_STRUCT(VGPIO_PCIE_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/fc60ca59_bb0ba4eb PS12, Line 457: // _PAD_CFG_STRUCT(VGPIO_PCIE_26, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/a6d70b61_19faa50c PS12, Line 458: // _PAD_CFG_STRUCT(VGPIO_PCIE_27, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/3b9729b8_6bba30e6 PS12, Line 459: // _PAD_CFG_STRUCT(VGPIO_PCIE_28, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/5f7fed95_fdd0829d PS12, Line 460: // _PAD_CFG_STRUCT(VGPIO_PCIE_29, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/1edfa707_360ed3dd PS12, Line 461: // _PAD_CFG_STRUCT(VGPIO_PCIE_30, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/d9349ed7_ab1b970c PS12, Line 462: // _PAD_CFG_STRUCT(VGPIO_PCIE_31, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/80e7cbfe_1f545130 PS12, Line 463: // _PAD_CFG_STRUCT(VGPIO_PCIE_68, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/1a5d01d1_c5fd87d4 PS12, Line 464: // _PAD_CFG_STRUCT(VGPIO_PCIE_69, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/8b0447e6_8a954b3b PS12, Line 465: // _PAD_CFG_STRUCT(VGPIO_PCIE_70, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150371): https://review.coreboot.org/c/coreboot/+/63656/comment/243fa19f_156a8930 PS12, Line 466: // _PAD_CFG_STRUCT(VGPIO_PCIE_71, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters