Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47010 )
Change subject: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 95: 65 After comparison of existing and these new added entries, observed that only this temperature trip value changed from 51 to 65 deg C. It seems all other new entries added here are the same as previous existing ones. Please, correct me if I am missing any other thing here. Thanks.
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 134: device generic 0 on : probe TABLETMODE TABLETMODE_DISABLED : end Just for better code readability, can we please add this after above "chip drivers/intel/dptf" line 84.
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 139: # Default DPTF Policy for all drawcia boards if not overridden : register "options.tsr[0].desc" = ""Memory"" : register "options.tsr[1].desc" = ""Ambient"" : register "options.tsr[2].desc" = ""Charger"" : register "options.tsr[3].desc" = ""5V regulator"" Is it possible to define these sensor description entries only once, instead of keeping for both these modes (tablet and non-tablet) because these are common entries which won't change for the system ?
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 188: device generic 1 on : probe TABLETMODE TABLETMODE_ENABLED : end Similar comment here as above, just for better code readability, can we please add this after above "chip drivers/intel/dptf" line 138.