Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68638 )
Change subject: mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ ......................................................................
mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ
The touchscreen IRQ has been configured as LEVEL_LOW in skyrim projects. Therefore, update the gpio.c to be consistent with the configuration.
BUG=b:253506651, b:251367588 BRANCH=None TEST=FW_NAME=frostflow emerge-skyrim coreboot
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: Iccfe5b01f10899c43151762e4730a05990afa602 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68638 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Chao Gui chaogui@google.com Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 22 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Chao Gui: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index b44114e..6062d93 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -51,7 +51,7 @@ /* AC_PRES */ PAD_NF(GPIO_23, AC_PRES, PULL_UP), /* SOC_FP_INT_L */ - PAD_SCI(GPIO_24, PULL_NONE, EDGE_LOW), + PAD_SCI(GPIO_24, PULL_NONE, LEVEL_LOW), /* GPIO_25: Not available */ /* PCIE_RST0_L */ PAD_NFO(GPIO_26, PCIE_RST0_L, HIGH),