Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36614 )
Change subject: soc/intel/common/sa: Properly guard the FSP-TOLUM cbmem_top implementation ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36614/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36614/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/common/sa: Properly guard the FSP-TOLUM cbmem_top implementation It's too long, drop "the" and "implementation"?
Though, actually, this is more about getting rid of EBDA, so maybe something like "Implement cbmem_top_chipset() without EBDA"?
https://review.coreboot.org/c/coreboot/+/36614/3/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/36614/3/src/soc/intel/common/block/... PS3, Line 9: initialize chipset?