[coreboot-gerrit] Change in coreboot[master]: nb/intel/nehalem: Don't run graphic init on S3 resume

[Arthur Heymans (Code Review)]

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35773 )

Change subject: nb/intel/nehalem: Don't run graphic init on S3 resume
......................................................................

nb/intel/nehalem: Don't run graphic init on S3 resume

The assumption is made that an ACPI aware an OS does not rely on
firmware to initialize the display.

TESTED on a Lenovo Thinkpad X201 with Linux 5.2, display still works
after S3, more than 200ms in time saved (dropped from 411ms to 182ms
in total in one test).

Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35773
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Patrick Rudolph 
---
M src/northbridge/intel/nehalem/gma.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c
index 4333307..903ee27 100644
--- a/src/northbridge/intel/nehalem/gma.c
+++ b/src/northbridge/intel/nehalem/gma.c
@@ -176,7 +176,8 @@
    if (!gtt_res || !gtt_res->base)
    	return;

-	if (CONFIG(MAINBOARD_USE_LIBGFXINIT)) {
+	if (!acpi_is_wakeup_s3() &&
+	    CONFIG(MAINBOARD_USE_LIBGFXINIT)) {
    	struct northbridge_intel_nehalem_config *conf = dev->chip_info;
    	int lightup_ok;
    	printk(BIOS_SPEW, "Initializing VGA without OPROM.");