Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41668 )
Change subject: jasperlake: enable DPTF functionality for dedede
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede...
PS2, Line 35: 1000, /* TimeWindowMinimum */
: 1000, /* TimeWindowMaximum */
You set it to MOBILE_SKU_PL1_TIME_SEC in the previous CL
Ack
https://review.coreboot.org/c/coreboot/+/41668/2/src/mainboard/google/dedede...
PS2, Line 43: 15000
Also in the devictree.cb PL2 is configured as 20 W whereas here it is 15 W. […]
Ack. It should be 20 W. I have submitted the updated patch for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41668
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17b6e4e96abee6181b0d1f94c356a32aa82c19b9
Gerrit-Change-Number: 41668
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 13:15:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment