Attention is currently required from: David Wu, Tarun Tuli, Nick Vaccaro, Eric Lai.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69559 )
Change subject: mb/google/brya/variants/volmar: Update ELAN touchscreen timing
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69559/comment/0ab615c7_915b673d
PS1, Line 11: Correct the delay time to 150ms to follow the spec.
Needn't warp line.
Fixed.
Patchset:
PS1:
Change to 150 will impact the resume time.
Yes.it will. But we need to follow the Elan's datasheet.
We also checked the resume time and the result is pass.(0.43s)
https://partnerissuetracker.corp.google.com/issues/257073343#comment23
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a30ed567cd676d0a9373527d93fe51f89d39e9
Gerrit-Change-Number: 69559
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 06:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment