[coreboot-gerrit] [XS] Change in coreboot[main]: acpi,soc: use is_domain0 function

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Fred Reitberger, Jason Glenesk, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Shuo Liu, Tim Chu, Tim Wawrzynczak.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83643?usp=email )

Change subject: acpi,soc: use is_domain0 function
......................................................................

acpi,soc: use is_domain0 function

No need to open-code this when we have a function for this.

Signed-off-by: Felix Held 
Change-Id: Iae570ba750cb29456436349b4263808e2e410e2e
---
M src/acpi/acpigen_pci_root_resource_producer.c
M src/soc/amd/common/block/data_fabric/domain.c
M src/soc/cavium/cn81xx/soc.c
M src/soc/intel/xeon_sp/uncore_acpi.c
4 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/83643/1

diff --git a/src/acpi/acpigen_pci_root_resource_producer.c b/src/acpi/acpigen_pci_root_resource_producer.c
index 78e1a89..ce57b9cc 100644
--- a/src/acpi/acpigen_pci_root_resource_producer.c
+++ b/src/acpi/acpigen_pci_root_resource_producer.c
@@ -60,7 +60,7 @@
    acpigen_resource_producer_bus_number(domain->downstream->secondary,
    				     domain->downstream->max_subordinate);

-	if (domain->path.domain.domain == 0) {
+	if (is_domain0(domain)) {
    	/* ACPI 6.4.2.5 I/O Port Descriptor */
    	acpigen_write_io16(PCI_IO_CONFIG_INDEX, PCI_IO_CONFIG_LAST_PORT, 1,
    			   PCI_IO_CONFIG_PORT_COUNT, 1);
diff --git a/src/soc/amd/common/block/data_fabric/domain.c b/src/soc/amd/common/block/data_fabric/domain.c
index b056d60..c419fe0 100644
--- a/src/soc/amd/common/block/data_fabric/domain.c
+++ b/src/soc/amd/common/block/data_fabric/domain.c
@@ -206,7 +206,7 @@
    read_non_pci_resources(domain, &idx);

/* Only add the SoC's DRAM memory map and fixed resources once */
-	if (domain->path.domain.domain == 0) {
+	if (is_domain0(domain)) {
    	add_pci_cfg_resources(domain, &idx);

read_soc_memmap_resources(domain, &idx);
diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c
index 81c9a64..e0caea6 100644
--- a/src/soc/cavium/cn81xx/soc.c
+++ b/src/soc/cavium/cn81xx/soc.c
@@ -386,8 +386,7 @@

static void enable_soc_dev(struct device *dev)
 {
-	if (dev->path.type == DEVICE_PATH_DOMAIN &&
-		dev->path.domain.domain == 0) {
+	if (is_domain0(dev)) {
    	dev->ops = &pci_domain_ops_ecam0;
    } else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
    	dev->ops = &soc_ops;
diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c
index 22f8b6f..0b2b9f4 100644
--- a/src/soc/intel/xeon_sp/uncore_acpi.c
+++ b/src/soc/intel/xeon_sp/uncore_acpi.c
@@ -560,7 +560,7 @@
    				    struct acpi_rsdp *rsdp)
 {
    /* Only write uncore ACPI tables for domain0 */
-	if (device->path.domain.domain != 0)
+	if (!is_domain0(device))
    	return current;

acpi_srat_t *srat;