Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75666?usp=email )
Change subject: soc/amd/stoneyridge/northbridge: use VGA_MMIO_* defines ......................................................................
soc/amd/stoneyridge/northbridge: use VGA_MMIO_* defines
Replace the magic constants by using defines.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I6303e5a697a7ad09a48cb7a2c79fa76f4c6ce232 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/stoneyridge/northbridge.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 90d227a..b4c18d3 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -7,6 +7,7 @@ #include <device/pci_ops.h> #include <arch/hpet.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <cbmem.h> @@ -365,7 +366,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 -> 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 -> 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB);