Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47311 )
Change subject: mb/google/zork: Power off fingerprint sensor on shutdown ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... PS3, Line 354: if (slp_typ == SLP_TYP_S5) {
What do you think Furquan? […]
Sorry, I missed posting an update here last week. I talked to Michael and he confirmed that zork devices have external pull-downs to ensure that the signals are driven low in case of reset (where the pads go back to their default state). I don't want to block this change from going in if it is required, but I think it would be good to evaluate if the weak pull down serves the purpose of ensuring that the signal is pulled low on reset. It also gets rid of the requirement of configuring the pads as GPO driven low early in bootblock. Can you please check on that and fix the flow as a follow-up if required.
Marking as resolved to continue landing this patch for now.