Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38378 )
Change subject: drivers/spi/spi_flash: introduce common spi_flash_part_id object ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... PS3, Line 79: const char *name; nit: Consider making this an array with hardcoded size (e.g. 10 like we had for winbond) and truncating names a bit if necessary. Since we're trying so hard to save size, 4/8 bytes for a pointer is a lot. (If you chose to keep it as a pointer, I'd move it to the top of the struct so you don't waste space on padding for 64-bit archs.)
Not that relevant if we get rid of names anyway, of course.
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... PS3, Line 82: uint16_t fast_read_dual_output_support : 1; nit: add a
_reserved_for_flags : 3;
here for documentation purposes. The space is used up anyway.