5 Aug
2019
5 Aug
'19
12:41 a.m.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34510 )
Change subject: security/vboot: Add Support for Intel PTT ......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34510/23/src/security/vboot/tpm_com... File src/security/vboot/tpm_common.c:
https://review.coreboot.org/c/coreboot/+/34510/23/src/security/vboot/tpm_com... PS23, Line 19: TPM_PCR_GBB_FLAGS_NAME
nit: please change the constant name as well (also, maybe "VBOOT: boot mode" and "VBOOT: GBB HWID" w […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/34510
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c9a839f53f96506be5fb68f7c1ed5bf6692505
Gerrit-Change-Number: 34510
Gerrit-PatchSet: 24
Gerrit-Owner: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Joel Kitching kitching@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 07:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment