Attention is currently required from: Fred Reitberger, Martin L Roth, Matt DeVillier.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76167?usp=email )
Change subject: Makefile.inc: relocate get_fmap_value() here from soc/intel/common/block/cse
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Note that there's also `fmap-section-offset-cmd`/`fmap-section-size-cmd` in `src/security/vboot/Makefile.inc`. Would probably make sense to pick one version and consolidate on that at some point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76167?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56a50e21b27a4cd6ce1a08a3aea338c63322a6b2
Gerrit-Change-Number: 76167
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 29 Jun 2023 23:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment