[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/rt1011: Add a driver for RT1011

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36029 )

Change subject: drivers/i2c/rt1011: Add a driver for RT1011
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36029/7/src/drivers/i2c/rt1011/chip... 
File src/drivers/i2c/rt1011/chip.h:

https://review.coreboot.org/c/coreboot/+/36029/7/src/drivers/i2c/rt1011/chip... 
PS7, Line 23: enum i2c_speed speed; /* Bus speed in Hz, default is I2C_SPEED_FAST */
Is this something that is configurable? If not, can we just assume I2C_SPEED_FAST in the driver and get rid of this member?

https://review.coreboot.org/c/coreboot/+/36029/7/src/drivers/i2c/rt1011/rt10... 
File src/drivers/i2c/rt1011/rt1011.c:

https://review.coreboot.org/c/coreboot/+/36029/7/src/drivers/i2c/rt1011/rt10... 
PS7, Line 94: RT1011_ACPI_NAME
If this same driver ends up getting used by multiple devices under the same parent, then there will be ACPI name collision.