[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 9:
> Patch Set 7:
> > Subrata, -2 simply means the change should not be merged
> > *as is*.
>
> [Subrata] Nice to know this.

Gerrit's semantics: -2 prevents a change from going in, while -1 is advisory only.
Therefore for "should not be merged as is", -2 is the right action to take.

And yes, we expect developers who hand out -2 to track changes made to such CLs so they can remove it once the concerns are resolved, see https://doc.coreboot.org/getting_started/gerrit_guidelines.html?highlight=-2...

But more on this entire mess by email.