Attention is currently required from: Cliff Huang, Jianeng Ceng, Lance Zhao, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi: Modify the order of increment operations
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82088/comment/e5d1c85d_f0a83a68 :
PS2, Line 7: acpi: Modify the order of increment operations
Maybe:
acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value
https://review.coreboot.org/c/coreboot/+/82088/comment/35fd1e1b_3e60f497 :
PS2, Line 11:
Please give more detail. The error was introduced in the commit making it public.
https://review.coreboot.org/c/coreboot/+/82088/comment/d4c558d5_10551e7d :
PS2, Line 13: TEST= Can get the correct index.
On what board did you test it?
Patchset:
PS2:
Eric, Kapil, the commit message is insufficient. Please be more vigilant in this regard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839
Gerrit-Change-Number: 82088
Gerrit-PatchSet: 2
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 25 Apr 2024 18:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment