Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31967 )
Change subject: soc/intel/common: Move eventlog support into common code
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31967/4/src/soc/intel/common/block/elog/elog...
File src/soc/intel/common/block/elog/elog.c:
https://review.coreboot.org/#/c/31967/4/src/soc/intel/common/block/elog/elog...
PS4, Line 38: static void pch_log_wake_source(struct chipset_power_state *ps)
Are all these pm1_sts bits really common across different platforms -- APL,GLK,KBL,WHL,CNL?
https://review.coreboot.org/#/c/31967/4/src/soc/intel/common/block/elog/elog...
PS4, Line 72: pch_log_power_and_resets
Are these all bits same across different platforms such that they can be made common?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf1f69b15487c9a08f1ddaeab055880eef9c2f24
Gerrit-Change-Number: 31967
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment