[coreboot-gerrit] [XL] Change in coreboot[main]: soc/meidatek/mt8196: Add SPM loader

[Ccong Chen (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.

Ccong Chen has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )

Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................

Patch Set 4:

(2 comments)

File src/soc/mediatek/common/Kconfig:

https://review.coreboot.org/c/coreboot/+/85599/comment/ffedaac1_ae3d07d4?usp... :
PS3, Line 122: version2. This version of the chip design
             : 	  has been simplified
> `version 2, where the chip design is simplified compared to version 1. […]

The simplified part is power on initial & bus protect initial

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/c96ba970_56d072b5?usp... :
PS1, Line 201: 	u8 reg_apifr_mem_apsrc_req_mask_b;
> You didn't answer my question. […]

The original definition is wrong. It's not setting for mt8196, and this code did not run before. The current setting is the first version of mt8196