Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34501 )
Change subject: Get HyperThreading setting from RW_VPD for FSP UPD ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34501/3/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c:
https://review.coreboot.org/c/coreboot/+/34501/3/src/soc/intel/fsp_broadwell... PS3, Line 132: : /* : * If RW_VPD VPD partition exists, search key/value pairs : * to see if there are relevant FSP UPD variable setting(s). : * If so, use such setting(s) to customize FSP behavior. : */ : if (CONFIG(VPD)) { : if (!fmap_locate_area_as_rdev("RW_VPD", &rdev)) { : search_address = rdev_mmap_full(&rdev); : if (search_address != NULL) { : search_length = region_device_sz(&rdev); : /* : * If there is a valid value for HyperThreading key in RW_VPD, : * use the value to customize FSP UPD HyperThreading variable. : */ : if (get_hyper_threading(&hyper_threading, search_address, : search_length) == true) { : UpdData->HyperThreading = hyper_threading; : } : } : } : } I wonder if it'll be easier to implement this as a board-specific callback, say
board_fsp_configure_upd_data(UPD_DATA_REGION *UpdData);
Then you can in your board handle your own VPD, and update the HT setting.