John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade ......................................................................
Patch Set 2:
(5 comments)
This change is ready for review.
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/52712/comment/db605e04_ba543eee PS1, Line 69: * Return: -1 if timeout error occuring
'occuring' may be misspelled - perhaps 'occurring'? […]
done
https://review.coreboot.org/c/coreboot/+/52712/comment/4f6befb3_193b0ce7 PS1, Line 243: * // Disable retimer online state
please, no space before tabs […]
done
https://review.coreboot.org/c/coreboot/+/52712/comment/e408b566_eaf42d2e PS1, Line 312: usb4_retimer_cb_get_power_state, /* Function 1 */
please, no space before tabs […]
done
https://review.coreboot.org/c/coreboot/+/52712/comment/40cb6130_211469af PS1, Line 313: usb4_retimer_cb_set_power_state, /* Function 2 */
please, no space before tabs […]
done
https://review.coreboot.org/c/coreboot/+/52712/comment/2db1a514_516fb7f5 PS1, Line 355: for(port = 0; port < config->dfp_num; port++) {
space required before the open parenthesis '(' […]
done