[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap().

[Tim Van Patten (Code Review)]

Attention is currently required from: Jason Glenesk, Matt DeVillier, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74716 )

Change subject: soc/amd/common/block: Add missing cbfs_unmap().
......................................................................

Patch Set 1:

(3 comments)

File src/soc/amd/common/block/cpu/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/74716/comment/f3487f90_e1f62384 
PS1, Line 89: cache_valid
Unrelated to these changes, but since you're in here...

`cache_valid` can be removed and replaced with `ucode_cache` here, since `find_microcode()` returns null (and we `cbfs_unmap()` if there's a failure).

https://review.coreboot.org/c/coreboot/+/74716/comment/ba4a7a52_e566c989 
PS1, Line 103: 			return;
Since `ucode` is static, it should be null'ed out here before returning, since the memory it's pointing to is no longer valid.

Same with the added `cbfs_unmap()` below.

File src/soc/amd/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/74716/comment/08d4bad7_ae2b9d3b 
PS1, Line 168: 	if (ram == NULL) {
             : 		printk(BIOS_ERR, "%s: Unable to load ROM for %s\n",
             : 		       __func__, dev_path(dev));
             : 	}
This is missing the `return`.