Attention is currently required from: Patrick Georgi, Martin L Roth, ron minnich.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59958 )
Change subject: util/docker/coreboot.org-status: Rewrite parser
......................................................................
Patch Set 17: Code-Review+2
(2 comments)
File util/docker/coreboot.org-status/board-status.html/boards.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/7698f603_464f97d1
PS17, Line 587: /*
: venboard := vendor + "/" + board
: if bi["Clone of"] != "" {
: venboard = bi["Clone of"]
: }
: */
Is it still needed? If so, maybe add some short comment about it?
File util/docker/coreboot.org-status/board-status.html/status-to-html.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/ab3cd885_f7df3c49
PS15, Line 71: dirs
I used it more as a structuring mechanism, akin to unix pipes. […]
Ok, thanks for clarifying
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2
Gerrit-Change-Number: 59958
Gerrit-PatchSet: 17
Gerrit-Owner: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 29 Oct 2022 08:53:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment