Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42830 )
Change subject: soc/amd/picasso: Add console & timestamp buffers to psp_verstage
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver...
PS3, Line 146: buffer_size = (uint32_t)((uintptr_t)_etimestamp - (uintptr_t)_vboot2_work);
Sorry, I think I'm missing something. […]
Ok, I see - it will *STILL* be null. I'll update the code to make sure it's not null when we need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c8d7a1565e761187e941d7d6021805a9744d06
Gerrit-Change-Number: 42830
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 16:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Gerrit-MessageType: comment