jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46458 )
Change subject: tests: Add lib/imd_cbmem-test test case ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c File tests/lib/imd_cbmem-test.c:
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 45: assert_ptr_equal(cbmem_top_chipset(), cbmem_top());
Where is cbmem_top_chipset() defined for this test?
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 111: static void test_cbmem_recovery(void **state)
This doesn't really test cbmem_recovery. […]
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 151: }
One important aspect of cbmem_add() is that when adding an ID that already exists, it will find the […]
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 168:
Please also check the sizes (and it might be nice if you could use something else than CBMEM_ROOT_SI […]
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 245: cbmem_add_bootmem();
You're just calling functions and ignoring their effects here, this doesn't really test anything. […]
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 264: assert_int_not_equal(0, size);
You should be able to check the exact values here (based on _cbmem_top_ptr and the size), not just t […]
Done
https://review.coreboot.org/c/coreboot/+/46458/9/tests/lib/imd_cbmem-test.c@... PS9, Line 284:
I think it might be good to have a general data structure format test: initialize CBMEM, add a few e […]
Done