Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6075
-gerrit
commit 38a84a93708fc409bc86d85d269e415ddbc86f18 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Fri Jun 20 06:21:01 2014 +0300
PCI VGA ROM: Use acpi_is_wakeup_s3()
Change-Id: I6f9c992f1a68025ed18de57c5856b3bf9a673bfb Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/device/pci_device.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 3a54c2d..f262586 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -30,6 +30,7 @@ #include <stdint.h> #include <string.h> #include <arch/io.h> +#include <arch/acpi.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> @@ -53,9 +54,6 @@ #if CONFIG_PC80_SYSTEM #include <pc80/i8259.h> #endif -#if CONFIG_HAVE_ACPI_RESUME && !CONFIG_S3_VGA_ROM_RUN -#include <arch/acpi.h> -#endif #if CONFIG_CHROMEOS #include <vendorcode/google/chromeos/chromeos.h> #endif @@ -687,14 +685,12 @@ static int should_run_oprom(struct device *dev)
static int should_load_oprom(struct device *dev) { -#if CONFIG_HAVE_ACPI_RESUME && !CONFIG_S3_VGA_ROM_RUN /* If S3_VGA_ROM_RUN is disabled, skip running VGA option * ROMs when coming out of an S3 resume. */ - if ((acpi_slp_type == 3) && + if (!IS_ENABLED(CONFIG_S3_VGA_ROM_RUN) && acpi_is_wakeup_s3() && ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA)) return 0; -#endif if (IS_ENABLED(CONFIG_ALWAYS_LOAD_OPROM)) return 1; if (should_run_oprom(dev))