Solomon Alan-Dei has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69021 )
Change subject: util/cbfstool: fix memory leak in compress.c ......................................................................
util/cbfstool: fix memory leak in compress.c
free the memory allocated in lz4_compress function before returning from it.
Reported-by: Coverity(CID:1469433)
Signed-off-by: Solomon Alan-Dei alandei.solomon@gmail.com Change-Id: I8698090d519964348e51fc3b6f2023d06d81fcd5 --- M util/cbfstool/compress.c 1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/69021/1
diff --git a/util/cbfstool/compress.c b/util/cbfstool/compress.c index 37fac22..96df1a7 100644 --- a/util/cbfstool/compress.c +++ b/util/cbfstool/compress.c @@ -23,9 +23,12 @@ if (!bounce) return -1; *out_len = LZ4F_compressFrame(bounce, worst_size, in, in_len, &prefs); - if (LZ4F_isError(*out_len) || *out_len >= in_len) + if (LZ4F_isError(*out_len) || *out_len >= in_len) { + free(bounce); return -1; + } memcpy(out, bounce, *out_len); + free(bounce); return 0; }