Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40368 )
Change subject: nb/i945: Reorder sdram_setup_processor_side()
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40368/3/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/40368/3/src/northbridge/intel/i945/...
PS3, Line 2717: if (i945_silicon_revision() == 0) {
Changing the order of undocumented register writes is not a good idea. What if there's an electrical dependency between these?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida21eb648f92ff0545dc0ce4da3aa9135b1260a9
Gerrit-Change-Number: 40368
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Apr 2020 13:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment