Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: mediatek/mt8192: add spmfw loader ......................................................................
Patch Set 24:
(5 comments)
We still have one comment that needs SPM DE's reply.
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... PS15, Line 926: 0x40000000
It's for SPM DMA's need. […]
Ack
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... PS15, Line 951: /* kick IM to fetch (only toggle IM_KICK) */
Right, so that change seems useless (but does not seem to make any difference, nevertheless... […]
Ack
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp... PS15, Line 1052: /* Kick PCM to run (only toggle PCM_KICK) */
Yes, intended.
Ack
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp... PS18, Line 12: #define SPMFW_HEADER_SIZE (16)
Yu-Ping Wu […]
Done
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp... PS18, Line 583: offset += SPMFW_HEADER_SIZE; /* binary start offset */
Yu-Ping Wu […]
Done