Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45924 )
Change subject: nb/intel/sandybridge: Use `postcar_enable_tseg_cache`
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
On hold until the purpose of caching what is marked as TSEG is clear.
https://review.coreboot.org/c/coreboot/+/45924/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/memmap.c:
https://review.coreboot.org/c/coreboot/+/45924/2/src/northbridge/intel/sandy...
PS2, Line 54: Cache the TSEG region using regular MTRRs. This is only useful
: * when SMRRs are not supported,
I don't think this is true. […]
Hrm, good point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5a851a6684c9aa96d1c30a8f8dc068d00f3b81
Gerrit-Change-Number: 45924
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 10:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment