Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: intel/fsp2_0: Add functions for adding Intel FSP version to coreboot table ......................................................................
Patch Set 13: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@9 PS13, Line 9: would be added is added
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@10 PS13, Line 10: is defined in [1]. The reference is not needed, as the commits are in the same branch and Gerrit (and once committed git) show the dependency.
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@12 PS13, Line 12: LinuxBoot payload cbmem utility Do you mean u-root? Do they have there own cbmem utility, which has an option to print the coreboot tables?
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@15 PS13, Line 15: [1] https://review.coreboot.org/c/coreboot/+/41809 As written above, this could be removed.
(For the future, I guess the Change-Id and commit message summary, should also be mentioned. Otherwise, once committed, (only) the URL makes it difficult to work with native git commands.)