William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42331 )
Change subject: mb/google/volteer: update volteer cbi definition
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42331/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42331/1/src/mainboard/google/voltee...
PS1, Line 7: DB_USB3_PASSIVE
Where do you see malefor using that?
Malefor define DB#1 during /project/volteer/malefor/config.star, but it seems not match baseboard EC code, I'll submit another CL to change it to 2.
Please notice that this CL add DB_USB3_PASSIVE which EC code not defined, see https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761893818231880d86fd13cfa61319157d06a7d5
Gerrit-Change-Number: 42331
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Tue, 16 Jun 2020 01:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment