[coreboot-gerrit] Change in coreboot[master]: drivers: spi_flash: Addressing mode change for SPI NOR

[Sudheer Amrabadi (Code Review)]

Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner, mturney mturney.
Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )

Change subject: drivers: spi_flash: Addressing mode change for SPI NOR
......................................................................

Patch Set 112:

(4 comments)

Patchset:

PS112: 
updated changes as per comments, can you please help to review.

File src/drivers/spi/Kconfig:

https://review.coreboot.org/c/coreboot/+/50586/comment/1443ff99_f27ba342 
PS111, Line 164: config SPI_FLASH_WINBOND_MODE3
> Please remove your previous code that is no longer used.

Ack

File src/drivers/spi/spi_flash.c:

https://review.coreboot.org/c/coreboot/+/50586/comment/a8aabc9b_bf6dc7a7 
PS111, Line 15: #define CMD_EXIT_4BYTE_ADDR_MODE 0xe9
> Please define this in spi_flash_internal.h with the rest of the commands.

Ack

https://review.coreboot.org/c/coreboot/+/50586/comment/60917b92_b2e42da6 
PS111, Line 521: #if (CONFIG(SPI_FLASH_EXIT_4_BYTE_ADDR_MODE) && ENV_INITIAL_STAGE)
> This can be if(), not #if

Ack