Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44627 )
Change subject: soc/intel/tigerlake: Configure IPU based on devicetree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44627/2/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44627/2/src/soc/intel/tigerlake/rom...
PS2, Line 171: m_cfg->VtdIpuEnable = 0x1;
: m_cfg->VtdBaseAddress[1] = IPUVT_BASE_ADDRESS;
I think we also need to check IPU status for this.
John can you please confirm if check is needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieff57fb0ebc8522546d6b34da6ca2f2f845bf61d
Gerrit-Change-Number: 44627
Gerrit-PatchSet: 2
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 19 Aug 2020 22:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment