Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31552 )
Change subject: soc/intel/cannonlake: Update GPIO definitions for Virtual GPIO ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31552/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31552/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/cannonlake: Update GPIO definitions for Virtual GPIO What about CNP-H? Any reason why that is not updated?
https://review.coreboot.org/#/c/31552/1/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/#/c/31552/1/src/soc/intel/cannonlake/include/soc... PS1, Line 200: vGPIO_0 Instead of using vGPIO_{0..39}, can we instead use the same names as the kernel does: https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/intel/pinctrl...