[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp: Fix SKX SATA drive boot issue

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47579 )

Change subject: soc/intel/xeon_sp: Fix SKX SATA drive boot issue
......................................................................

Patch Set 3:

(6 comments)

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 
PS2, Line 9: cpx
> CPX

Done

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 
PS2, Line 9: x2apic
> I'd use uppercase: X2APIC

Done

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 
PS2, Line 9: skx
> SKX

Done

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@9 
PS2, Line 9: Skx
> I'd use uppercase: SKX

Done

https://review.coreboot.org/c/coreboot/+/47579/2//COMMIT_MSG@10 
PS2, Line 10: X2API
> X2APIC

Done

https://review.coreboot.org/c/coreboot/+/47579/2/src/soc/intel/xeon_sp/nb_ac... 
File src/soc/intel/xeon_sp/nb_acpi.c:

https://review.coreboot.org/c/coreboot/+/47579/2/src/soc/intel/xeon_sp/nb_ac... 
PS2, Line 447: #if
> Definitely: […]

Done