Attention is currently required from: Cliff Huang, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email )
Change subject: device: Add inline method to identify PATH_ROOT
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80169/comment/cef7b2bc_0a2498eb :
PS1, Line 166: extern DEVTREE_CONST struct device dev_root;
I don't see how the compiler could optimize something. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80169/comment/493eb098_83e57dac :
PS1, Line 467: dev->bus->dev == dev
Would it make sense to document this on line 87 of main.c in sconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59
Gerrit-Change-Number: 80169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Tue, 23 Jan 2024 09:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment