Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Bryant Ou,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43454
to look at the new patch set (#5).
Change subject: 2/4 mb/ocp/tiogapass/gpio: undo set trig and bufdis for NF pads ......................................................................
2/4 mb/ocp/tiogapass/gpio: undo set trig and bufdis for NF pads
According to the documentation [1], RX Level/Edge Configuration (trig) and GPIO Tx/Rx Buffer Disable (bufdis) [2] settings are not applicable in native mode and BIOS does not need to configure them. Therefore, there is no need to configure this in gpio.h using PAD_CFG_NF_BUF_TRIG macros. Use PAD_CFG_NF instead and set these fields to 0.
[1] Intel document #549921 [2] Intel document #336067-007US
This is part of the patch set "src/mb/*, src/soc/intel/common/gpio: Remove PAD_CFG_NF_BUF_TRIG ":
CB:43455 - 1/4 cedarisland: undo set trig and bufdis for NF pads CB:43454 - 2/4 tiogapass: undo set trig and bufdis for NF pads CB:43561 - 3/4 h110m: undo set trig and bufdis for NF pads CB:43569 - 4/4 soc/intel/common/gpio_defs: Remove PAD_CFG_NF_BUF_TRIG
Change-Id: Icdb6cb39934548e125461929701b33477a74f2a2 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h 1 file changed, 66 insertions(+), 66 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43454/5