Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35176 )
Change subject: util/lint: make clang-format non-fatal
......................................................................
Patch Set 2: Code-Review+1
I remember this being very confusing when I tried to make my first patch, especially since no one else seemed to be following the suggested clang-format rules. Right now it generates so much noise that until the style guide becomes mandatory (eg. integrated into Jenkins) then I think it should just be disabled entirely.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffa8934efa1c27c04e10545f66d8f9976e74c367
Gerrit-Change-Number: 35176
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Sep 2019 03:49:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment