16 Jun
2019
16 Jun
'19
1:03 a.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )
Change subject: soc/intel/cannonlake: set use of legacy 8254 timer ......................................................................
Patch Set 1:
I'll double check if it's needed for Tianocore as well.
Tiano booted just fine with USE_LEGACY_8254_TIMER=y and TIANOCORE_USE_8254_TIMER=n
The FSP integration guide says "Make sure [Enable8254ClockGating] is disabled to support boot legacy OS using 8254 timer" -- so perhaps the Kconfig should be 'DISABLE_LEGACY_8254_TIMER' vs 'USE_LEGACY_8254_TIMER' or something to that effect?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33512
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e888bf754cb72093f14fc02f39bddcd6d288203
Gerrit-Change-Number: 33512
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jeremy Soller jackpot51@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Jun 2019 23:03:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment