Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42831 )
Change subject: soc/amd/picasso: Use cbfs to locate the AMD firmware ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42831/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42831/7//COMMIT_MSG@12 PS7, Line 12: the binary
Which binary requires the hard coding? Is it possible to also remove this hard coding?
The AMD firmware table requires the addresses. The initial pointer for the bootloader is interpreted at least in part by hardware (or built in code), so I don't think it's possible to change this easily.
https://review.coreboot.org/c/coreboot/+/42831/6/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42831/6/src/soc/amd/picasso/psp_ver... PS6, Line 94: psp_dir_addr = ef_table->psp_table;
I think a comment here would go a long way for indicating the point of the math below.
I'm refactoring this section in follow-on patch. Also, I believe that Zheng Bao may be refactoring this tool as well, but I'm not sure what he's doing other than replacing the command line arguments with a config file instead.