Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80102?usp=email )
Change subject: soc/intel/xeon_sp: Drop code to locate the UBOX bus
......................................................................
Patch Set 9:
(2 comments)
File src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h:
https://review.coreboot.org/c/coreboot/+/80102/comment/9969248c_6338096d :
PS9, Line 27: uint8_t get_stack_busno(const uint8_t stack);
optional to have wording fixes here or leave to later discussions. close the open.
Done
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/80102/comment/10860842_188ad914 :
PS9, Line 27:
optional to have wording fixes here or leave to later discussions. close the open.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b18f02f62b69ec7c73cd5665102cb6bfc6e64b5
Gerrit-Change-Number: 80102
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 06 Feb 2024 09:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment