Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33746 )
Change subject: soc/intel/cannonlake: Allow coreboot to reserve stack for fsp
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
I am having serious issues with this on my Whiskey Lake system (System76 Galago Pro galp3-c). This causes FspMemoryInit to fail with INVALID_PARAMETER.
Please let me know if you have any questions
What FSP version are you using?
The latest version, Coffee Lake 7.0.64.40
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0778ee21cb4f66b8ec884b77788c05a73c609be6
Gerrit-Change-Number: 33746
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jeremy Soller
jackpot51@gmail.com
Gerrit-Comment-Date: Fri, 04 Oct 2019 20:27:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment