Attention is currently required from: Haribalaraman Ramasubramanian, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80504?usp=email )
Change subject: soc/intel/alderlake: Remove CNVi assertions
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80504/comment/f0791568_e0e3ae95 :
PS4, Line 12: This seems to make sense and allows us
: to enable CNVi bluetooth when necessary.
Do you want to have some mechanism at runtime to change them?
Yes. Currently in Brox some SKUs within a same design use discrete WiFi/BT module and some use CNVi/BT as indicated in the TEST message. This is decided by probing the FW_CONFIG mask at run-time.
I still don't understand. You want to change from not booting due to asserts to booting with error messages? That hardly sounds like a good idea. Why not fix the mainboard code and update the config at runtime, rather than have the common code accept invalid configurations?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I822a4e360fde100b8289cacf10a01f6d97facbb4
Gerrit-Change-Number: 80504
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:14:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment