Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 21:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 10: 3
For chrome systems, CSE region will have 3 paritions only if CSE supports FW update. […]
Done
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 781: partition_id != BP1 && partition_id != BP2
Sure, I will capture the details in the comments.I will check on spec, and get back to you on it.
Done
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 153: enum
For chrome system,CSE region will have max 3 partitions. So, no change to existing enum definations. […]
Done
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 147: MAX_ME_PARTITIONS
I will move definition of CSE_MAX_BOOT_PARTITIONS to header file.
Done
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 150: BP_STATUS_SUCCESS = 0, : BP_STATUS_GENERAL_FAILURE = 1, : BP_STATUS_PARTITION_NOT_PRESENT = 2, : BP_STATUS_HOST_REQUEST_FOR_PARTITION_SWITCH = 3,
Can you please add comments indicating what each really means?
Done