[coreboot-gerrit] [M] Change in coreboot[master]: NOTFORMERGE/WIP/POC edk2 devicetree

[build bot (Jenkins) (Code Review)]

Attention is currently required from: Martin L Roth, Stefan Reinauer.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68719 )

Change subject: NOTFORMERGE/WIP/POC edk2 devicetree
......................................................................

Patch Set 1:

(7 comments)

File src/lib/device_tree.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/4cc9e4a1_8175aaf0 
PS1, Line 148: 		printk(BIOS_DEBUG, "/memreserve/    0x%016llx 0x%016llx\n", reserved_entry->start, reserved_entry->size);
line length of 121 exceeds 96 columns

File src/lib/fit_payload.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/b9e11cce_394980b1 
PS1, Line 113: 	static const char *framebuffer_path[] = {"framebuffer", NULL};
static const char * array should probably be static const char * const

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/0d10a7df_51b5270a 
PS1, Line 115: 								 framebuffer_path, &addr_cells, &size_cells, 1);
line length of 112 exceeds 96 columns

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/3ad9d65e_6cbfac02 
PS1, Line 212: 		{CBMEM_ID_WIFI_CALIBRATION, "coreboot-wifi-calibration", "coreboot-wifi-calibration"},
line length of 102 exceeds 96 columns

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/210c8dc8_6046afe5 
PS1, Line 220: 		const struct cbmem_entry *cbmem_entry = cbmem_entry_find(sections_ids[i].cbmem_id);
line length of 99 exceeds 96 columns

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/0c83e3bd_40452f5e 
PS1, Line 226: 		const char *node_path[] = { sections_ids[i].dt_node, NULL};
char * array declaration might be better as static const

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161099):
https://review.coreboot.org/c/coreboot/+/68719/comment/566174db_3ffc4241 
PS1, Line 231: 		dt_add_reg_prop(dt_node, &section_base, &section_size, 1, addr_cells, size_cells);
line length of 98 exceeds 96 columns