Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45450 )
Change subject: nb/intel/gm45: Put register definitions into separate files
......................................................................
Patch Set 3:
Patch Set 3:
What's the motivation here?
Basically, to slim down gm45.h (or any other northbridge's <northbridge>.h header). This isn't much of a problem with gm45, though, as there aren't many definitions to move.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bb3c907565ef2a278b748b1b7771dbd11d42df9
Gerrit-Change-Number: 45450
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 19:40:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment