Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31802 )
Change subject: src/soc/intel/apollolake/cpu.c: Set up local APIC
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31802/1/src/soc/intel/apollolake/cpu.c
File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/#/c/31802/1/src/soc/intel/apollolake/cpu.c@167
PS1, Line 167: CONFIG_PAYLOAD_SEABIOS
May be you should remark that this KConfig switch is only set when integrating SeaBios during the co […]
You're right. I removed the switch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00b339ce1850729023db74da7f8845927a95dcc6
Gerrit-Change-Number: 31802
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Mar 2019 09:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-MessageType: comment