Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36386 )
Change subject: src/soc/intel: skl,cnl,icl: remove unneeded check in cbmem_top()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36386/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36386/2//COMMIT_MSG@10
PS2, Line 10: Since this is not the case anyways remove the guard that
: checks if MRC is finished and returns NULL if not.
Just "Therefore drop the check to see if MRC finished."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I964a20a5e9aa69fdb75413c36a17d34b7ba00098
Gerrit-Change-Number: 36386
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Oct 2019 20:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment