Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45554 )
Change subject: mb/getac/p470/acpi: Convert 'battery.asl' to ASL 2.0 syntax ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45554/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45554/5//COMMIT_MSG@9 PS5, Line 9: Changes the binary using 'BUILD_TIMELESS=1'. Probably because of optimization. : Generated "dsdt.dsl" are same. I would say:
IASL optimizes the code differently, which changes the binary. However, the generated `build/dsdt.dsl` remains identical.
https://review.coreboot.org/c/coreboot/+/45554/5/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/45554/5/src/mainboard/getac/p470/ac... PS5, Line 81: 0x64 hmmmmm, 100?
https://review.coreboot.org/c/coreboot/+/45554/5/src/mainboard/getac/p470/ac... PS5, Line 84: 0x64 hmmmmm
https://review.coreboot.org/c/coreboot/+/45554/5/src/mainboard/getac/p470/ac... PS5, Line 189: 0x64 hmmmmm
https://review.coreboot.org/c/coreboot/+/45554/5/src/mainboard/getac/p470/ac... PS5, Line 196: One 1