[coreboot-gerrit] Change in coreboot[master]: arch/x86: Flip option NO_CAR_GLOBAL_MIGRATION

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34804 )

Change subject: arch/x86: Flip option NO_CAR_GLOBAL_MIGRATION
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34804/4/src/arch/x86/Kconfig 
File src/arch/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/34804/4/src/arch/x86/Kconfig@227 
PS4, Line 227: 	depends on !CAR_GLOBAL_MIGRATION
> If we previously had POSTCAR_STAGE=y, it implied NO_CAR_GLOBAL_MIGRATION=y. I think the policy does not change here, it's one or the other you can have enabled.

It didn't imply; it enabled that ability because of the CAR teardown being in postcar. Now you are saying that postcar can only be enabled if !CAR_GLOBAL_MIGRATION which is not technically true (though I don't see why one would try that).

It's probably better to indicate in commit description that a policy is being enforced as well (it also keeps people from doing weird things).